Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CRM-21544 - Remove unused CRM_Contact_BAO_Contact_Optimizer class #11400

Merged
merged 1 commit into from
Dec 13, 2017
Merged

CRM-21544 - Remove unused CRM_Contact_BAO_Contact_Optimizer class #11400

merged 1 commit into from
Dec 13, 2017

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented Dec 12, 2017 •
edited by civicrm-builder
Loading

Overview

Remove inactive code

Technical Details

The class CRM_Contact_BAO_Contact_Optimizer has one function that is called & it looks like

public static function edit(&$newValues, &$oldValues) {
// still need to do more work on this
// CRM-10192
return;

Also a call to
$customFields = CRM_Core_BAO_CustomField::getFields($params['contact_type'], FALSE, TRUE);

Where custom fields is never used.

@colemanw
Copy link
Member

colemanw commented Dec 12, 2017 •
edited
Loading

Lol. // todo: Everything

@colemanw colemanw merged commit 4fe5b08 into civicrm:master Dec 13, 2017
@eileenmcnaughton eileenmcnaughton deleted the removal branch December 13, 2017 21:49
sluc23 pushed a commit to ixiam/civicrm-core that referenced this pull request Jan 10, 2018
@colemanw @sluc23
Merge pull request civicrm#11400 from eileenmcnaughton/removal
cca95a7 
CRM-21544 - Remove unused CRM_Contact_BAO_Contact_Optimizer class
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eileenmcnaughton @colemanw @civicrm-builder